Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reach skip option #1794

Open
wants to merge 1 commit into
base: 2.0
Choose a base branch
from
Open

Conversation

Axionize
Copy link
Contributor

Add a config option to skip reach checks for non-player targets. Useful for performance and if you don't care about KA or reach on mob grinders and mobs.

@ManInMyVan
Copy link
Contributor

I think there should be a warning to not enable this because of falses without reporting it

@Axionize
Copy link
Contributor Author

What are you talking about? I don't quite understand what you're trying to say. This does not cause falses (if anything it would hide falses assuming they exist, which for reach is just not true). This just skips reach check if the target is not a player.

@ManInMyVan
Copy link
Contributor

What are you talking about? I don't quite understand what you're trying to say. This does not cause falses (if anything it would hide falses assuming they exist, which for reach is just not true). This just skips reach check if the target is not a player.

reach falses on non-player entity -> this gets enabled -> false never gets reported -> false never gets fixed

@ItsClairton
Copy link
Contributor

What are you talking about? I don't quite understand what you're trying to say. This does not cause falses (if anything it would hide falses assuming they exist, which for reach is just not true). This just skips reach check if the target is not a player.

reach falses on non-player entity -> this gets enabled -> false never gets reported -> false never gets fixed

There are already false positives involving Reach with entities that are not Players. In version 1.8, at least, I was able to reproduce false positives involving Horse, Elder Guardian, and Skeleton.

@ManInMyVan ManInMyVan added the status: rebase required The pull request needs rebasing onto the merge branch label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: rebase required The pull request needs rebasing onto the merge branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants